C# Brain Scratcher of the Day

We ran into the following issue two days ago.  In a nutshell, the “initialCategory” was not being selected in the Categories dropdown by default.  Yes, I recognize that the code itself may be written in fewer lines, but please only focus on the differences between the two code snippets below.  I haven’t had the time to research, but this code has been rolling around in my head ever since a developer presented the “fix” to me yesterday morning.  As far as I can tell, only syntax has changed.  I would expected the code to work in both case, to be honest, but the “before” code didn’t function correctly with our last release.

Any thoughts?

Before

for(int i=0;i<cboCategories.Items.Count;i++)
{
    if(initialCategory != string.Empty)
    {
        if(cboCategories.Items[i].Value.ToLower()==initialCategory.ToLower())
        {
            cboCategories.Items[i].Selected=true;
            break;
        }
    }
    else if(cboCategories.Items[i].Value==all)
    {
        cboCategories.Items[i].Selected=true;
        break;
    }
}

After

for(int i=0;i<cboCategories.Items.Count;i++)
{
    if(initialCategory != string.Empty)
    {
        if(cboCategories.Items[i].Value.ToLower()==initialCategory.ToLower())
        {
            //cboCategories.Items[i].Selected=true;
            cboCategories.SelectedIndex = i;
            break;
        }
    }
    else if(cboCategories.Items[i].Value==all)
    {
        //cboCategories.Items[i].Selected=true;
        cboCategories.SelectedIndex = i;
        break;
    }
}